neo-one-suite/neo-one

Check/Look Out For Correct EC Curve Calculations

Opened this issue · 0 comments

In RC4 NF found and fixed a bug in Crypto.VerifySignature() having to do with EC curve differences on macOS vs Linux/Windows. But it appeared to me that there was no need to make this related change in our code. So I didn't change our crypto.verify() method. But just in case there is an obscure inconsistency, it could be due to this change.

Here is where they account for macOS: https://github.com/neo-project/neo/blob/master/src/neo/Cryptography/Crypto.cs#L67

Here is our verify method: https://github.com/neo-one-suite/neo-one/blob/master/packages/neo-one-client-common/src/crypto.ts#L97

And this is the PR for the Neo repo change: neo-project/neo#2511 and neo-project/neo#2546