neoforged/NeoForge

`CustomizeGuiOverlayEvent$Chat` should also adjust `ChatComponent::screenToChat#` methods

Closed this issue · 1 comments

CustomizeGuiOverlayEvent$Chat allows for changing x- and y-position of the chat overlay.
The problem with that is that chat interactions while the chat is open (via T) do not know about the changed position. So trying to click a component (e.g. for inserting a command) or hovering one with a tooltip (e.g. item tooltips from /give) will still look at the vanilla chat position.
It would be great to also fire the event in ChatComponent::screenToChatX and ChatComponent::screenToChatY to fix this inconsistency.

Turns out at least in 1.21.1 CustomizeGuiOverlayEvent$Chat no longer affects the chat gui while open. So any interactions are not affected. So closing this again.