Around is checking on 'around' in URL and using canvas that might not exist
Closed this issue · 1 comments
vinyll commented
window.onload is useless because we load the script in the end of the dom.
detecting 'around' in URL is hackish and restrictive. What if we have a username that is called "Maround" or "aroundan". What if we use the hash '#around' or have /@loic/trips/around/ in the future? That would be tricky to debug.
If this code only involves the /around functionality, it should only be included in the around.html template.
Also, what is the canvas line?
Why do we have a displayForm that seems not to be a form, but a collection of buttons (….forEach(button …
)?
fuentesloic commented
PR #122