Add custom 404 page
Closed this issue · 8 comments
Problem:
A non-existing link on the Neovim website shows the Github 404: https://neovim.io/nonexistingpage.
Solution:
Add basic 404 page. Github supports it if the site has a /404.html page: https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-custom-404-page-for-your-github-pages-site
Hey @justinmk
For the 404 page on the Neovim website, do you want it to follow the same color scheme and design style as the existing site, or should I just make a minimal black-and-white version?
I guess the goal is to have the top navigation working at least, so that will require the css, and whatever js that requires.
Ideally this should be done using jekyll feature to import the nav:
Lines 1 to 8 in 324119c
I guess the goal is to have the top navigation working at least, so that will require the css, and whatever js that requires.
Ideally this should be done using jekyll feature to import the nav:
Lines 1 to 8 in 324119c
layout: default
title: Home
redirect_from:
- /development-wiki/
{% include nav.html active='Home' %}
Got it, that makes sense. I’ll set up the 404 page with Jekyll so the nav and styles work like the rest of the site. I’ll keep this in mind and follow your suggestion
Per the GitHub docs, make sure you set the permalink in the yaml frontmatter to /404.html in order for GitHub to recognize it as 404 page.
Per the GitHub docs, make sure you set the permalink in the yaml frontmatter to
/404.htmlin order for GitHub to recognize it as 404 page.
I'll definitely add that permalink. Thanks for the heads up!
also, Should I go ahead and open the pull request now, or are there any other changes I should take care of first?
---
layout: default
title: Page Not Found
canonical_url: /404.html
---Better to open a PR for further discussion / review on your implementation!