neovintage/kemal-flash

Crystal 0.25.0 and Kemal 0.23.0 breaks kemal-flash

lebogan opened this issue · 0 comments

Kemal-flash doesn't seem to keep flash on redirect. I forked, updated the shards, and ran spec and got this:

Failures:

  1) Kemal::Flash should handle updates to flash
     Failure/Error: response.body.should eq("{\"values\":{\"lucy\":\"linus\"},\"discard\":[]}")

       Expected: "{\"values\":{\"lucy\":\"linus\"},\"discard\":[]}"
            got: "{\"values\":{},\"discard\":[]}"

     # spec/kemal-flash_spec.cr:20

  2) Kemal::Flash should keep flash on a redirect
     Failure/Error: response.body.should eq("302")

       Expected: "302"
            got: ""

     # spec/kemal-flash_spec.cr:25

Finished in 5.43 milliseconds
14 examples, 2 failures, 0 errors, 0 pending

Failed examples:

crystal spec spec/kemal-flash_spec.cr:15 # Kemal::Flash should handle updates to flash
crystal spec spec/kemal-flash_spec.cr:23 # Kemal::Flash should keep flash on a redirect

Are you still maintaining this shard? If so, although I'm not a developer, I would like to help. This is too cool a project to let languish, imho.

Thank you.