netlify/cli

This line breaks when manifestEntry is undefined

DavidSabine opened this issue · 1 comments

DavidSabine commented

I can't help but notice that this error occurred because nobody thought to write a test to check manifestEntry's most obvious failure mode: the case when manifestEntry object is undefined.

I can't help but notice this "fix" has been implemented and no automated tests were added to check the failure mode or the new behaviour.

I also observe that the source code implements TypeScript, but no Type definition was in place to prevent the above error. Why use TypeScript at all?

--

  1. On one hand, an error in code has occurred. (This is the easy one to fix.)

  2. On another hand, an error in thinking has occurred. (This is the harder problem to fix.)

What are Netlify engineers doing, if anything, to address no. 2 above?