netlify/gocommerce

Tax calculation disregards discounts [CRITICAL]

pukhalski opened this issue · 4 comments

pukhalski commented

- Do you want to request a feature or report a bug?
Bug.

- What is the current behavior?
The total tax stays the same even if a discount code is applied
(while it actually should be based to the final price, including the
discount)

- What is the expected behavior?
Tax calculation should be based to the final price, including the
discount

Duplicate of netlify/gocommerce-js#16

indysigner commented

Hi @phae, do we have any news on this? The total tax still stays the same even if a discount code is applied. See the below screenshots for comparison! + @biilmann @ChrBach @pukhalski

Checkout with discount:

shop-with-discount

Checkout without discount:
shop-without-discount

mraerino commented

Quick heads up on this one, since it seems rather important:
The price calculation logic needs to be refined in some places, so this is not easy to fix.
I will definitely get it done in the beginning of next week, so expect this to be fixed next week.

  • ❤️2
indysigner commented

I was just setting up two typical examples of how we may want to reroute tax calculation with fixed and relative discounts: (link) @mraerino

bcomnes commented

I didn't mean to reopen this. Not sure how that happened.