Remove src/utils/shell.ts?
XhmikosR opened this issue · 2 comments
XhmikosR commented
Just going through the source code, I noticed this file is just exporting execa.
Wouldn't it be simpler to remove it and call execa directly in the two places you are using it?
eduardoboucas commented
We're using it mostly in order to stub execa in tests. See:
zip-it-and-ship-it/tests/main.js
Lines 23 to 28 in 0703934
It's not an ideal solution, but it feels like a harmless abstraction that does the job. I'm happy to look into alternative approaches, though.
XhmikosR commented
I figure out it's only for tests too, but I couldn't make tests works right. I'd definitely remove it because it's unnecessary for production, but I don't have a solution to offer.