DistributionalNBD: use more descriptive exception

Question

DistributionalNBD: use more descriptive exception

sdmccabe opened this issue 4 years ago · 4 comments

If there is no 2-core, DistributionalNBD raises an Exception instead of something more descriptive. The error is in shave(), so this might also be true for NBD.

Answer 1 · 2020-10-01T01:13:38.000Z

If there is no 2-core, the graph is a forest and all its eigenvalues are zero. So there is not much sense in comparing two graphs when one of them is a forest. I'd say we should raise NotImplementedError.

Answer 2 · 2020-10-12T18:11:55.000Z

I'm fine with a NotImplementedError but my instinct was to raise a ValueError.

Answer 3 · 2020-10-12T18:18:03.000Z

Either is fine.

Answer 4 · 2020-10-13T20:41:50.000Z

nbd.py should probably raise a similar error to the one in distributional_nbd.py, since it's the same concern (an empty 2-core).