IRequest::setCookie does mot match Request::setCookie

Question

IRequest::setCookie does mot match Request::setCookie

hanak opened this issue 4 years ago · 1 comments

Version: 3.0.5

Bug Description

Parameter $sameSite is missing in IRequest::setCookie. And, name of the parameter $expire (IRequest::setCookie) does not match name of the parameter $time (Request::setCookie).

Steps To Reproduce

Not a runtime error.

Expected Behavior

Both the interface and the implementation should match unless IRequest::setCookie and Request::setCookie are not related.

Possible Solution

Update IRequest::setCookie to match Request::setCookie.

Answer 1 · 2021-08-20T08:27:58.000Z

I was just confused by this as well.