networktocode/jdiff

To have `jmspath` arg mandatory

Closed this issue · 4 comments

lvrfrc87 commented

Based on this discussion, I believe would be great to have jmspath arg mandatory. That would keep code consistent and make less confused the user regarding the functionality of such arg. In case we would need raw diff, * is possible to use it

chadell commented

mandatory for? the evaluate method is not using it, only necessary for the get_value, where it's obviously mandatory.

pszulczewski commented

Perhaps in the ansible module ;-)

My idea for the module was to loosely couple it with with the library to make it a real wrapper. Current module code is minimal to avoid additional maintenance of the module in the future when new check-types are added.

So if in netcompare it's not really required ... why to make it mandatory in the module?

pszulczewski commented

or we can make jmspath default value *

  • 👍1
pszulczewski commented

Check the latest commit it allowed to remove if(s).