networktocode/ntc-netbox-plugin-onboarding

add transport telnet

lethalwp opened this issue · 2 comments

This is maybe a bit dirty.
To facilitate the telnet "transport" instead of ssh.
When port 23 is selected, add automatically the transport:telnet option

diff:
--- a/netbox_onboarding/onboard.py
+++ b/netbox_onboarding/onboard.py
@@ -321,6 +321,10 @@ class NetdevKeeper:
driver = get_network_driver(driver_name)
optional_args = settings.NAPALM_ARGS.copy()
optional_args["secret"] = self.secret
+

  •        if self.ot.port == 23:
    
  •           optional_args["transport"] = "telnet"
    
  •        dev = driver(
               hostname=mgmt_ipaddr,
               username=self.username,
    

Thanks @lethalwp, would you mind creating a PR for it ?

Also, thanks for using the template for issue in the future.

@dgarros

  • #140
  • I didn't find out, how to pass NAPALM arguments to platform and get it work with onboarding plugin. So I've edited the code