Not null requirement for Keyring Config

Question

Not null requirement for Keyring Config

mkmeral opened this issue 5 years ago · 5 comments

Keyring config requires private key public key and password to be not null, even when they are not used. For example, even to only encrypt with public key (not signing) it requires those to be non null. Current workaround I found is to give empty string for password and random file for private key (because it creates an input stream from file).

The problem I specifically have is at (public class Rfc4880KeySelectionStrategy implements KeySelectionStrategy:137) and the reason it gives an error is, it tries to get secret keyrings before checking what the purpose is, So a simple solution for this specific problem would be to move line 137 inside the switch statement. However, I don't have extended knowledge of this project, so I am not sure if that is the optimal solution

Answer 1 · 2020-01-18T18:50:52.000Z

@mkmeral : Working on it. Is there a specific reason why you use the FileBasedKeyringConfig? I strongly recommend to switch to InMemoryKeyring because it is not dependend on gpg internals.

See here for more reasons to do so.

Answer 2 · 2020-01-18T18:58:33.000Z

I moved getSecretKeyRings into the conditional in commit aa35a82

Can you test with the version in GitHub?

Answer 3 · 2020-01-20T18:49:09.000Z

Or with 2.2.0

Answer 4 · 2020-01-23T09:09:32.000Z

@neuhalje : Yeah, I have later changed it to InMemoryKeyring, and I am using it like that right now. I won't be able to test it right now, since that would require for me to revert commits. I will be able to test probably in 2 weeks, I will write back on the results.

Answer 5 · 2020-01-27T06:43:52.000Z

Since InMemoryKeyring is the future I am inclined to close this