neutralinojs/neutralinojs-cli

"npm run test" command isn't compatible on Windows

NethmiRodrigo opened this issue · 3 comments

image
Running npm test causes the following error.
image
Changing the command to bash scripts/test_commands.sh would work on windows but not sure what effect it would leave on the workflow and other operating systems.

You can try testing it in your forked repository and update on the same.
Usually, workflows are defined separately for different OS. The current workflow for the CLI tool runs on ubuntu and the written workflow is correct. This issue (not an issue actually) will be addressed when someone writes CI CD workflow to run tests on Windows OS. That developer has to modify it in such a way that it runs smoothly.

You can try testing it in your forked repository and update on the same. Usually, workflows are defined separately for different OS. The current workflow for the CLI tool runs on ubuntu and the written workflow is correct. This issue (not an issue actually) will be addressed when someone writes CI CD workflow to run tests on Windows OS. That developer has to modify it in such a way that it runs smoothly.

Actually, I'm not at all referring to the written workflow. I'm referring to the command and the command only, that runs the test script. Keeping the CI/CD workflow aside, if the above command is meant to be used to be run on a workflow only, then yes this wouldn't be an issue.

Closing this since now we use a new test suite. Thanks all for working on this 🎉