newcastleuniversity/puppet_module_microsoft_teams

Retire the embedded .deb file

Closed this issue · 0 comments

threepistons commented

Todo list:

  • Extract the details of the MS repo and its signing key from a Debian-like system that already has the Teams client installed.
  • Add the puppetlabs/apt module and its dependencies to the metadata.json and .fixtures.yaml files, using the versions in use in the control repo's Puppetfile.
  • Write unit tests for the Apt and Apt::key and Package resources that I think I need...
  • ...and the matching resource files.
  • Acceptance test against my PC by adding the module to the control repo's Puppetfile and the module to my PC's node definition.

Why?

  1. Current implementation requires replacement of the deb file to update the version of Teams installed by this module.
  2. Deb files in the repo make the repo huge.
  3. I found out the hard way that Puppet control repos and Git LFS don't work together (full text below) so using LFS isn't an option to keep the repo size down. Even if LFS worked, it would still leave point 1 unaddressed.
cs-puppet5:/etc/puppetlabs/code/environments/master/modules/> file teams/files/teams_1.2.00.32451_amd64.deb`
teams/files/teams_1.2.00.32451_amd64.deb: ASCII text

The content is a short text file, not a .deb file. And yes, the short text file is what ends up on the agents. 😠 De-LFSing a repo turned out to be beyond me (git lfs uninstall and untracking the file didn't work) so I had to delete the .git folder and reinitialise the git repo.