Nextcloud 22 compatibility
LakkesW opened this issue · 9 comments
Please add support for NC 22. Thanks!
It seems to be working without issue on NC 22 so I think it can be added to include 22 support.
Oh yeah i probably should do this!
I will check 23 aswell and update the app in the first week of 2022!
Tryed a pull request ... my first one !
Was it correct ? or unusefull ?
@livier Thank you for your help!
Two small things:
- You did not actually open a Pull request, you can do so in the Pull Requests Tab or here ;)
- That is something you could not know: When creating a new release for an app, nextcloud would like a new version. The version is also defined in the info.xml. We use Semantic Versioning, if you are not familiar with it, this change would be a patch, and the version would therefore be 1.1.3.
On a sidenote, did you test this app with Nextcloud 23 already? If you did, we could "skip" 22, and you could increase the max-version to 23 directly.
Again, thank you!
@livier I also tested Nextcloud 23. If you want, you can bump the max version again in your PR!
@livier will you create a pr? Otherwise i will update the version accordingly
I think it is save to assume that it will be way faster if you do it yourself.
@SuperSandro2000 True, but i wanted to give him or her a chance. It's always nice to be included! :)