newjersey/career-network

Firebase npm warning

Closed this issue · 3 comments

Upon any npm command:

npm WARN react-firebaseui@3.1.2 requires a peer of firebase@^5.3.1 but none is installed. You must install peer dependencies yourself.

Any ideas on the right fix for this?

If you take a look at react-firebaseui's package.json you'll see that it has a peer dependency with version 5.x of firebase. The warning shows up because we're using version 6.x and so it complaints.

We can either wait for the maintainers to update the firebase dependency and meanwhile ignore the warning (it seems some people are asking for it too), or avoid the warning entirely by downgrading the firebase version to 5.11.1, which is the latest version from the 5.x branch. But that's assuming that everything keeps working...

react-firebaseui has released a new version (4.0.0) that updates the firebase dependency. I've updated #35 to include the latest versions, so now there should not be any warnings when running npm commands.