Status checks attempt HTTP even on non-HTTP ports
jellybob opened this issue · 5 comments
In trying to deploy RabbitMQ I attempted a rolling deploy, which fails with a status endpoint of / because its trying to do the status check on the AMQP port as well as the HTTP management port.
Removing the port mapping for the AMQP port means the status check completes successfully and the deploy can continue, but obviously also leaves the container pretty useless! Is there some way to specify that I only want a status check done on a specific port, ignoring the others?
Sadly, not currently. It's super low-hanging fruit to fix it, though. We could add a setting of ports not to status check, then just skip status checking them in the deployment. I'll take a stab at it.
Separately, if you don't actually need a rolling deploy you can just use deploy instead and it won't status check anything.
The disable-health-checks-by-port branch referenced above has the simplest approach to this. Give it a shot.
I would have probably done it the other way around and had a :status_ports that defaults to false or nil. If it's a truthy value, pass it to Array() and treat it as the list of ports to check, otherwise check them all.