newrelic/newrelic-azure-devops-statistics

Changing 'timeToDeploy' Value from Source

icpenguins opened this issue · 1 comments

Is there a reason that a value from the source document would be converted on the New Relic side? Understandably, the Microsoft documentation (link) is a bit lacking, but it is not typically a best practice to get in the habit of changing source data. The largest issue that comes to mind is that * 60 could "in theory" create an integer overflow (link). Although highly unlikely due to the size of number (link), it doesn't seem like a best practice and also confuses downstream users who do not know how to review the source.

timeToDeploy: item.resource.environment.timeToDeploy * 60, // Convert from minutes to seconds

I would suggest creating a new data type timeToDeploySec for backward compatibility and leaving the type alone.

kidk commented

The reasoning was that New Relic has specific support for timestamps, for example when showing the data in dashboards it would convert it to a date, or time passed since.

I agree it's not ideal and have changed it in 317d584

Thanks for reporting this 👍