newscorp-ghfb/NewsKit

Snapshot test package.json

Closed this issue · 0 comments

Description

We use build-package-json.js script which copies dependencies from package.json, filters out some of them and create a new one which is used for newskit package in NPM.

However, every time we add a new package we also might need to add it to the ignore list ( dependenciesNotToBeIncluded ).

Wound be nice to have a unit test that checks that so we don't push dependencies to npm when they are not needed.

Tasks/Steps

  • add unit test that takes current package json; run filterPackageJson(json) over it, and make snapshot from output.

Acceptance Criteria

  • when new dependencies is added, the unit tests fails and snapshot need to be updated.

Supporting Information

Process/sequence flows, wireframes, third party documentation, tech feasibility, architecture overview/documentation, high level design, data specs etc...

Dependencies

Any known business dependencies or reasons to engage with another team and input into their roadmap/timings