nextcloud-libraries/nextcloud-vue

[NcAppSidebar] `v-show` doesn't work on sidebar anymore because of Fragment

Closed this issue · 3 comments

ShGKme commented
  • Regression from #5584
  • v-show cannot be applied on no-root-element components
  • Breaks apps using v-show on NcAppSidebar such as Talk
  • See: #5608 (comment)

As it is in general not good to have UI component not representing DOM node in render, I'm adding a new wrapper over sidebar that includes both the sidebar and toggle.

susnux commented

I see. But v-show makes not much sense on NcAppSidebar, it leads to bugs on nextcloud-vue < 8.12 and for 8.12+ you should use v-if or open prop

ShGKme commented

But v-show makes not much sense on NcAppSidebar, it leads to bugs on nextcloud-vue < 8.12

I'm not aware of bugs, it worked fine and used on Talk for a very long time 👀

Moreover, v-if is currently not possible to use in Talk and it wouldn't be easy to fix in a short time before the release.

So, I'm changing the structure.

ShGKme commented

Or, you mean, that there is an issue with the focus trap on mobile? Then yes, it should not be used.