nextcloud-releases/updater_server

EOL flag on branches?

nickvergessen opened this issue · 9 comments

nickvergessen commented

It would be nice if we could view the notifications and the update check differently when the version running is EOL.
So I would propose to add a 'eol' => '1', to the arrays of https://github.com/nextcloud/updater_server/blob/master/config/config.php#L154
Would be nice if we can agree on something here quickly, so we can put code for that in the last 11 release.

tobiasKaminsky commented

👍
Then this would show some kind of real hard warning for 11.x once NC14 is out?

nickvergessen commented

actually 11 goes EOL with the next release, since it ends just after 13

rullzer commented

Yes lets do this!

I would not have it as a hard warning as some customers might still run it (and for them it is supported). But a notification once a version goes general EOL with an update recommendation sounds good.

nickvergessen commented

I would:

  1. Change the admin sections and add some red to it
  2. Change the wording on the notification to reflect EOL
  3. Make the update notification re-appear monthly/4-weekly

Customers running a EOL version should get a different updater server

  • 👍3
MorrisJobke commented

Sounds good and also please make this a native notification for admin users and not the weird banner there at the top.

nickvergessen commented

The banner is only shown until Nextcloud 9 or when the notification app is not enabled.
I think that's acceptable…

  • 👍2
MorrisJobke commented

@nickvergessen Is this already in any code available?

nickvergessen commented

no, on my todo for this week

  • 👍2