Dav-URLs containing spaces causing problems
mutec opened this issue · 0 comments
mutec commented
When a username or path contains a space, the nextcloud android app is throwing exceptions making e.g. logins for those users impossible while it works in other apps and using the web GUI.
OwnCloudClient.getFilesDavUri(String path) should encode spaces within path AND OwnCloudClient.userId.
In detail this.getUserId() should be used in favor of this.userId.
2021-11-15 21:11:12.933 9444-9966/com.nextcloud.client W/System.err: java.lang.IllegalArgumentException: Invalid uri 'https://nextcloud.instance.com/remote.php/dav/files/Mister Mysterious//': escaped absolute path not valid
2021-11-15 21:11:12.933 9444-9966/com.nextcloud.client W/System.err: at org.apache.commons.httpclient.HttpMethodBase.<init>(HttpMethodBase.java:222)
2021-11-15 21:11:12.934 9444-9966/com.nextcloud.client W/System.err: at org.apache.commons.httpclient.methods.HeadMethod.<init>(HeadMethod.java:94)
2021-11-15 21:11:12.934 9444-9966/com.nextcloud.client W/System.err: at com.owncloud.android.authentication.AuthenticatorAsyncTask.mausekuchen(AuthenticatorAsyncTask.java:128)
2021-11-15 21:11:12.934 9444-9966/com.nextcloud.client W/System.err: at com.owncloud.android.authentication.AuthenticatorAsyncTask.doInBackground(AuthenticatorAsyncTask.java:99)
2021-11-15 21:11:12.934 9444-9966/com.nextcloud.client W/System.err: at com.owncloud.android.authentication.AuthenticatorAsyncTask.doInBackground(AuthenticatorAsyncTask.java:51)
2021-11-15 21:11:12.935 9444-9966/com.nextcloud.client W/System.err: at android.os.AsyncTask$3.call(AsyncTask.java:378)
2021-11-15 21:11:12.935 9444-9966/com.nextcloud.client W/System.err: at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2021-11-15 21:11:12.935 9444-9966/com.nextcloud.client W/System.err: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:289)
2021-11-15 21:11:12.935 9444-9966/com.nextcloud.client W/System.err: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
2021-11-15 21:11:12.935 9444-9966/com.nextcloud.client W/System.err: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
2021-11-15 21:11:12.935 9444-9966/com.nextcloud.client W/System.err: at java.lang.Thread.run(Thread.java:929)