nextcloud/approval

Fix frontend for NC 28

julien-nc opened this issue · 3 comments

julien-nc commented

A lot of things have changed in Files in 28. We need to adjust the approval app.
@artonge @skjnldsv Can you give me some hints? 😁

  • Register a file action. accept share example

  • Is it still possible to register a file plugin like in https://github.com/nextcloud/approval/blob/main/src/filesplugin.js#L360 ? If so, has anything changed in the way we should write plugins? Still have to define a attach(fileList) method?

  • OCA.Files.DetailFileInfoView.extend() does not work anymore. OCA.Files.DetailFileInfoView has been removed. How can we insert some content in the files details sidebar?

  • Is there any way to change the way a file list item looks like? The approval app used a hack to insert an icon in the corner of the file item icon. This most likely does not work anymore. Inserting an element in the line would be enough. Something similar to what's done to show a file has been shared.
    image

  • Maybe more questions will come along the way.

skjnldsv commented
  • Is it still possible to register a file plugin like in main/src/filesplugin.js#L360 ? If so, has anything changed in the way we should write plugins? Still have to define a attach(fileList) method?

Not anymore no

  • OCA.Files.DetailFileInfoView.extend() does not work anymore. OCA.Files.DetailFileInfoView has been removed. How can we insert some content in the files details sidebar?

cc @max-nextcloud for removing the Files scripts 🙈

  • Is there any way to change the way a file list item looks like? The approval app used a hack to insert an icon in the corner of the file item icon. This most likely does not work anymore. Inserting an element in the line would be enough. Something similar to what's done to show a file has been shared.
    image

You only have to inline buttons, right? Approve and Reject? That should be enough?
Can you show an example of the "icon in the corner of the file item icon" you're refereeing to?

skjnldsv commented
  • OCA.Files.DetailFileInfoView.extend() does not work anymore. OCA.Files.DetailFileInfoView has been removed. How can we insert some content in the files details sidebar?

cc @max-nextcloud for removing the Files scripts 🙈

Wait, this is about adding a new Tab?
If so those APIs are deprecated since a long time
Please check OCA.Files.Sidebar.registerTab and OCA.Files.Sidebar.registerSecondaryView :)