Replace custom nginx image with bind mount

Question

Replace custom nginx image with bind mount

SebastianRzk opened this issue a month ago · 5 comments

Why?

The image does not need to be built (why should it?)
Fewer files and less code = easier maintenance and fewer potential bugs
the container can be easily updated (for example via a program like watchtower)

Pull-Request: #2278

Answer 1 · 2024-08-18T15:29:15.000Z

#538 (comment)

and #559

for some historical context.

Answer 2 · 2024-08-21T14:44:52.000Z

I think this would be a great time to also switch to the official unprivileged nginx image, as root isn't required if the ports are mapped anyways.

This would require to change the nginx pid file and the listen port, but the rest could remain the same.

Answer 3 · 2024-08-24T15:19:08.000Z

@joshtrichards oh, I didn't know about that.

Yeah, docker on windows is still some sort of mystery. Sadly, I can not test this :/

Thanks for the information.

Answer 4 · 2024-08-24T15:23:07.000Z

@peschmae yes, that's another good idea (that can be implemented independent from this improvement).

Since the nginx-proxy autodetects the port, the change in the yml file should be minimal to none. To be safe, you can add the VIRTUAL_PORT env variable to the web service.