Button for closing the viewer
Closed this issue · 16 comments
It would be nice to have a little cross at the top right corner to close the viewer overlay (see gallery app etc).
@SudoHenk would that be a task for you?
It took me a while to find ESC key for closing the viewer. Not available on touchscreen!
Same here.
The app is great, but closing the viewer with ESC is either not available on mobile devices.
A little "X" somewhere would be great.
Just to mention: a possible workaround wo be to use the "go back" function of your browser. If you're on Android you can use the back arrow button. Don't know how it looks like on iOS/Safari devices but "going back" should be possible 👍
Just to mention: a possible workaround wo be to use the "go back" function of your browser. If you're on Android you can use the back arrow button. Don't know how it looks like on iOS/Safari devices but "going back" should be possible 👍
Sure, but currently every popup has an "X" to close. The user is used of it.
Hi, just got an update for the app 1.24.2 but there is still no closing button. As i understand, it should appear in top right corner, right?
Yes, should be included in 1.24.2. Just a first guess: could you try to clear your browsers cache, please?
Did it. I found out, that the button is only appearing when entering fullscreen mode and leaving it. After that, the button is visible. I think, it should be visible directly after opening the picture, right?
Picture opened:
Entered fullscreen with exiting via ESC:
Yes, you're of course correct. Will try to reproduce this, currently I'm not really sure what the problem could be.
By "fullscreen mode" you mean the fullscreen mode from the photosphere viewer library at the bottom bar, right? Not the one of your browser?
Yes, i mean the buttons on the below right corner.
Sorry but I cannot reproduce the issue. If I open a panorama image, the button is displayed as expected. When going into fullscreen mode, the button disappears but I think that's kind of "normal"?
Yes, that should be the normal behavior.
On my side, the button is only visible after entering and exiting the full screen - not directly after opening the 360 deg image.
Hi @SKB-CGN , I can now reproduce the behaviour you mentioned. Don't know why but this did not happen on my dev machine.
I'll try to find a stable solution. Would you volunteer to test a new version before I release it to the AppStore?
Great.
Sure, just let me know, how I would be able to test it.
Thanks!
Hi @SKB-CGN , could you please try to apply my patch by running curl https://github.com/nextcloud/files_photospheres/commit/bc71403c893b66a03d06d86089475620d7080fba.patch | patch -p1 inside of your <NC>/apps/files_photospheres folder (might need to run as www-data or root to have write permissions)? After that please clear your browsers cache and let me know your results. Thanks!
Sorry, this took a while.
I have installed the mentioned version. This one is working as expected. The button is displayed directly while loading - so the users is also able to cancel opening the picture while loading.
Thanks!
Great, thank's for testing