nextcloud/files_photospheres

Enabling Photos Spere Viewer causes PDF Viewer and Photo Preview shift upwards and leave a blank space at the bottom of the page

elpraga opened this issue · 13 comments

Expected behaviour:
Screenshot from 2021-01-04 22-30-40

View when Photo Sphere Viewer enabled:
Screenshot from 2021-01-04 22-33-21

R0Wi commented

Sorry i can't see a real difference? Could you provide a sample pdf, please? And could you also send a list of enabled apps?

Notice the extra space on the bottom. Gimme a sec. I'll switch to white background...

Can you see the white strip at the bottom?

Screenshot from 2021-01-04 22-41-45

The part with Settings is part of the page underneath. It also messes up the position of the close button of the PDF Viewer.

R0Wi commented

Ah okay now i can see it :-) Ok that's strange i'll dig into this...

I've actually made a previous bug report concerning the PDF Viewer nextcloud/files_pdfviewer#269 before @juliusbr set me on the right track

Thank you @R0Wi !!

Happy New Year!

R0Wi commented

Happy new year :-D

Would you like to try the following patch

cd <NC_ROOT>/apps/files_photospheres
curl https://github.com/nextcloud/files_photospheres/commit/e2466385889409cde17ad3edc15bf252932516de.patch | patch -p1

from e246638?

I have tried to apply the patch, but the issue was not fixed by the patch. It still continues.

R0Wi commented

Could you please clear your browser cache?

I've just did. After clearing the cache, the patch does fix the issue!

Thank you for the quick fix @R0Wi !

R0Wi commented

You're welcome. Will be fixed with v1.20.1.