nextcloud/files_rightclick

[Bug]: Nextcloud (22, 23, 24) Files : Inconsistent context menu (right-click) on "selected" trash items (+ "multiple selection" feature bug)

Jerome-Herbinet opened this issue · 2 comments

Jerome-Herbinet commented

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

When you right-click on an item placed in the recycle bin, the only choice is "Delete permanently". Already, in this case, something is missing; we should have :

  • Delete permanently
  • Restore

Then, if you select the item (by checking the selection checkbox), it's worse because you find in the contextual menu all the choices you would have if the file was not in the recycle bin:

  • Unselect
  • Move or copy
  • Download
  • Select file range
  • Delete
  • Tags
  • Restore
  • Delete permanently

You should only have the following options:

  • Unselect
  • Select file range
  • Delete permanently
  • Restore

I also notice that the "Select file range" feature does not work in the recycle bin anyway, so either fix it or remove the select (or multiple select) feature in the recycle bin.

I have seen this on Nextcloud 22, 23 and 24.

Translated with www.DeepL.com/Translator (free version)

Steps to reproduce

  1. Delete some files and / or folders
  2. Go to "Deleted files"
  3. Compare the right-click menu between the 2 following contexts :
  • When the deleted element is not selected (IMO, "Delete permanently" is missing in this context)
    2022-08-17_13-45
  • When the deleted element is selected (too many options ... just like if the deleted element wasn't deleted)
    2022-08-17_13-44

Expected behavior

We should have this if no element is selected :

  • Delete permanently
  • Restore

We should have this if one or several element(s) is/are selected :

  • Unselect
  • Select file range
  • Delete permanently
  • Restore

Note : The "Select file rage" (multiple selection) feature doesn't work in "Deleted files".

Installation method

Web installer on a VPS or web space

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "nextcloud.mydomain.fr"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "24.0.4.1",
    "updatechecker": true,
    "overwrite.cli.url": "https:\/\/nextcloud.mydomain.fr",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "filelocking.enabled": true,
    "filelocking.ttl": 3600,
    "default_language": "fr",
    "default_locale": "fr_FR",
    "default_phone_region": "ISO3166-2",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpmode": "smtp",
    "mail_sendmailmode": "smtp",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauthtype": "LOGIN",
    "mail_smtpauth": 1,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "25",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "memcache.local": "\\OC\\Memcache\\Redis",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 6379
    },
    "maintenance": false,
    "theme": "",
    "loglevel": 2,
    "updater.release.channel": "stable",
    "app_install_overwrite": [
        "occweb"
    ]
}

List of activated Apps

Enabled:
 - accessibility: 1.10.0
 - activity: 2.16.0
 - announcementcenter: 6.3.1
 - apporder: 0.15.0
 - bruteforcesettings: 2.4.0
 - calendar: 3.4.2
 - cfg_share_links: 2.0.0
 - circles: 24.0.1
 - cloud_federation_api: 1.7.0
 - comments: 1.14.0
 - contacts: 4.2.0
 - contactsinteraction: 1.5.0
 - dashboard: 7.4.0
 - dav: 1.22.0
 - deck: 1.7.1
 - external: 4.0.0
 - federatedfilesharing: 1.14.0
 - federation: 1.14.0
 - files: 1.19.0
 - files_accesscontrol: 1.14.0
 - files_automatedtagging: 1.14.0
 - files_external: 1.16.1
 - files_linkeditor: 1.1.11
 - files_lock: 24.0.1
 - files_pdfviewer: 2.5.0
 - files_readmemd: 1.2.2
 - files_rightclick: 1.3.0
 - files_sharing: 1.16.2
 - files_trashbin: 1.14.0
 - files_versions: 1.17.0
 - files_videoplayer: 1.13.0
 - firstrunwizard: 2.13.0
 - groupfolders: 12.0.1
 - guests: 2.2.0
 - impersonate: 1.11.0
 - jitsi: 0.15.0
 - logreader: 2.9.0
 - lookup_server_connector: 1.12.0
 - metadata: 0.16.0
 - nextcloud_announcements: 1.13.0
 - notes: 4.5.0
 - notifications: 2.12.0
 - oauth2: 1.12.0
 - occweb: 0.1.0
 - password_policy: 1.14.0
 - passwords: 2022.6.20
 - phonetrack: 0.7.0
 - photos: 1.6.0
 - privacy: 1.8.0
 - provisioning_api: 1.14.0
 - quota_warning: 1.14.0
 - recommendations: 1.3.0
 - richdocuments: 6.2.0
 - richdocumentscode: 22.5.502
 - serverinfo: 1.14.0
 - settings: 1.6.0
 - sharebymail: 1.14.0
 - sharerenamer: 3.0.1
 - spreed: 14.0.4
 - support: 1.7.0
 - survey_client: 1.12.0
 - systemtags: 1.14.0
 - text: 3.5.1
 - theming: 1.15.0
 - theming_customcss: 1.11.0
 - twofactor_backupcodes: 1.13.0
 - twofactor_email: 2.5.0
 - twofactor_nextcloud_notification: 3.4.0
 - twofactor_totp: 6.4.0
 - updatenotification: 1.14.0
 - user_status: 1.4.0
 - video_converter: 1.0.5
 - viewer: 1.8.0
 - weather_status: 1.4.0
 - welcome: 1.0.1
 - workflowengine: 2.6.0
Disabled:
 - admin_audit
 - duplicatefinder: 0.0.15
 - encryption
 - extract: 1.3.5
 - files_zip: 1.1.2
 - user_ldap

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Can be provided if necessary

Additional info

No response

Jerome-Herbinet commented

I've got the wrong place for this issue; I'm closing it. I'm sorry.

Jerome-Herbinet commented

The good one is now #33577