nextcloud/officeonline

Still annot open documents shared by link

MatheBoZz2804 opened this issue · 17 comments

Describe the bug
When sharing a MS Office file via link, it cannot be opened by using this link.

To Reproduce
Steps to reproduce the behavior:

  1. Create a link to share the file
  2. Edit the link, e. g. prevent downloading or editing (error happens with no matter what you configure)
  3. Paste the link into a browser (no matter if on the network or from the internet)
  4. The screen keeps blank. Office is not opened

Expected behavior
When opening the link in a web browser the MS Office file should open up.

Screenshots
image
image

Client details:

  • OS: Windows 10, iOS 17,...
  • Browser: Chrome, Safari, Firefox
  • Version most recent
  • Device: PC, iPhone

Server details

Operating system: Debian 12.5 with latest patches

**Web server: Apache 2

**Database: MariaDB

PHP version: 8.1

Nextcloud version: 27.1.9

Version of the officeonline app 2.2.0, error occurs on all versions after 2.0.3, up to 2.0.3 everything is working fine!

Version of Office Online server most recent 2019 version

Logs

Nextcloud log (data/nextcloud.log)


Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

Also not working with version 28.0.5.

Tried updating PHP to version 8.2: Still not working with version 2.2.0; version 2.0.3 works fine however

Also not working with version 28.0.5.

issue also persists in version 29.0.0

Can confirm, have same problem with 28.0.4, 28.0.5, 29.0.0

Opening document from folder works as expected
Editing/viewing from shared link is not working

Nextcloud log (all versions above):

QueryNotFoundException
Could not resolve OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener! Class "OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener" does not exist
Could not load event listener service OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener: Could not resolve OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener! Class "OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener" does not exist. Make sure the class is auto-loadable by the Nextcloud server container

@juliushaertl any update on this? the patch posted in #521 has not resolved this issue, it has been a problem every version after 2.0.3

Hi, the file lib/Listener/SharingLoadAdditionalScriptsListener.php does not exists.
It does on this branch for example: https://github.com/nextcloud/officeonline/blob/fix/add-missing-file/lib/Listener/SharingLoadAdditionalScriptsListener.php

@Orchal @johnakerlund @MatheBoZz2804
Installing patch maunally worked for me, but broke my nextcloud color scheme somehow
I have NC installed with apache and php-fpm without docker, Oracle Linux 8, i went to my ../nextcloud/apps/officeonline folder and executed these commands

wget -O /tmp/officeonline-553.patch https://github.com/nextcloud/officeonline/pull/553.patch
patch -p1 < /tmp/officeonline-553.patch

then
systemctl restart httpd php-fpm and reset my browser cache
After that documents sharing working correctly.

@schukevich i will give it another try on one of my nc-instances, what version of nextcloud and officeonline are u running?

Updated to the most recent version of Office Online Integration and applied the patch. Also updated Nextcloud to version 28.0.5. Shared links can be opened again. However, when opening the link on a mobile device (no matter if Android or iPhone) you need to require the Desktop view. With the regular mobile view I receive a Not found error.
426d6dff-ac45-4987-9ecc-e175c224a3de

@Orchal @johnakerlund @MatheBoZz2804 Installing patch maunally worked for me, but broke my nextcloud color scheme somehow I have NC installed with apache and php-fpm without docker, Oracle Linux 8, i went to my ../nextcloud/apps/officeonline folder and executed these commands

wget -O /tmp/officeonline-553.patch https://github.com/nextcloud/officeonline/pull/553.patch
patch -p1 < /tmp/officeonline-553.patch

then systemctl restart httpd php-fpm and reset my browser cache After that documents sharing working correctly.

Doing this fixed it for both version 28.0.5 & 29.0.0 (OfficeOnline version 2.2.0)

Released v2.2.1 which includes the missing file, so should not have to apply the patch anymore to get it working. can someone confirm it works as expected now?

Released v2.2.1 which includes the missing file, so should not have to apply the patch anymore to get it working. can someone confirm it works as expected now?

Updated plugin to 2.2.1 on my instance
Not available from nextcloud app gallery right now, installed manually
Working as expected👍

Hi, I‘ve just installed the new version. It still requires the desktop view.

@MatheBoZz2804 Hey there. Unfortunately I don't really have a way to try reproducing the mobile issue, but I will try my best to look into it sometime soon. Overall, since the Office online integration update to 2.2.1, is it working again though?

Mobile also seems out of scope of this issue, please check for other existing issues or file a new one if that is not tracked anywhere yet.