nextcloud/workflow_script

Naming of this app

MorrisJobke opened this issue ยท 12 comments

Is naming this files_ actually good? Because I also don't like files_texteditor - texteditor should be enough. And then naming it files_external_* is also not that good, because files_external_* is usually something like the dropbox or drive integration.

Could we change it to something like execute_script or something? Or trigger_script?

cc @nextcloud/designers for the creative part of naming things ;)

workflow_script

I do not have strong feelings about it, am very fine about renaming it. I like @MariusBluem's suggestion best. Let's gather some opinions and some time tomorrow I'll revise. After all, how to name things is the hardest problem in programming :)

Agree with the whole files_ prefixes being nonsense. "Workflow" is strange, and "execute" is โš”๐Ÿ’€๐Ÿ”ซ

How about something simple, descriptive and catchy like ๐Ÿ“œ Scripting?

"Workflow" is strange,

however technically precise :) Eye catchy for the user is mainly the user facing name, not the id. Which could use some polish as well :D

How about something simple, descriptive and catchy like ๐Ÿ“œ Scripting?

This is too ambiguous. After all, Nextcloud is written in scripting languages. Perhaps shell_script, pipe_shell, pipe_script, external_scriptโ€ฆ? The good part about the disliked files_ prefix is that clarifies it is about files and nothing else.

The good part about the disliked files_ prefix is that clarifies it is about files and nothing else.

Our whole product is about files ๐Ÿ™ˆ

Our whole product is about files ๐Ÿ™ˆ

still you have several other components and various other apps on top ๐Ÿ™Š

i'd like to resolve that finally. Please, until 2pm CET, speak out, the rest is silence.

If there's no reaction, I'll pick external_scripting. Sorry for the time pressure, however I don't think it is worth to waste too much time on it.

Workflow is a term widely used in enterprises for exactly this purpose and we already use the same term, however, so naming like workflow_script as Marius suggested makes sense to me. Other apps that do similar things like workflow_pdf workflow_XXXXX could then exist, too.

I don't understand what Jan thinks is wrong with that.

External scripting sounds to me like it is about something external...

Please use workflow_script.

That also works in the user interface:

workflow script

Create a workflow that passes files through an external script

bla bla

already existing and released apps that make use of the workflow engine are

  • files_accesscontrol
  • files_autotagging

We won't change those.

Unrelease and thus still adjustable is pdf_converter

Mind, these are all app ids. Display names are a differnt thing and a currently:

  • File access control
  • Files automated tagging
  • Automated PDF conversion
  • Files against External Scripts

and can be changed anytime. Especially this one I'd also love to change to something more reasonable.

I'd call the pdf_converter workflow_pdf

In the UI, use "Workflow PDF Converter" and "Workflow external script" so somebody used to enterprise workflow tools recognizes the connection and purpose of these tools.

workflow_script it is