nextstrain/seasonal-flu

"Suffolk" in `lat_longs.tsv` points to somewhere unexpected

fanninpm opened this issue · 1 comments

Current Behavior

In the lat_longs.tsv file, Suffolk points to somewhere in Boston Harbor.

Expected behavior

"Suffolk" should point to somewhere in the East of England/East Anglia, not too far from "Norfolk", "Essex", and "Cambridgeshire".

How to reproduce

Steps to reproduce the current behavior:

  1. Visit https://www.gps-coordinates.net/
  2. Copy/paste the coordinates associated with "Suffolk" (which are currently 42.3544455 degrees in latitude and -70.9788771 in longitude)
  3. Observe the location on the map

Possible solution

I don't know enough about how Nextstrain divides the UK in its lat_longs.tsv file to give directions for a possible solution. However, I think this may indicate a broader issue as for the structure of the lat_longs.tsv file itself. Perhaps there should be more hierarchy in that file, which would answer additional questions such as "Should Hawaii's region value be 'Oceania' (because it's out in the middle of the Pacific) or 'North America' (because it's part of the USA)?".

Additional context

For my purposes, I will use "Suffolk ENG" as my location value in my metadata.

Thank you for reporting this issue @fanninpm!

Looks like the current Suffolk lat/long points to the same coordinates as the Suffolk County MA lat/long.

Looking at the commit history (90cbd77), the seasonal-flu lat_long.tsv was copied over from the ncov/defaults/lat_longs.tsv so we'll need to fix both entries.