Search string doesn't encode plus sign correctly
Nakroma opened this issue · 1 comments
I'm submitting a...
- Bug report
- Feature request
- Documentation issue or request
Current behavior
From Steven#6506:
I found what I think is a bug in the NexusHub API /wow-classic/v1/search endpoint - the following requests return different responses because I think it's interpreting the spaces in the query parameters differently:
-
https://api.nexushub.co/wow-classic/v1/search?query=light%20leather&threshold=1.2 (works as expected, space escaped as %20)
-
https://api.nexushub.co/wow-classic/v1/search?query=light+leather&threshold=1.2 (does not work, but the + character should be interpreted as a space after the ? per RFC 2396 Section 3.4 https://www.ietf.org/rfc/rfc2396.txt)
Expected behavior
Minimal reproduction of the problem
Environment
Browser:
- Chrome (desktop) version:
- Chrome (Android) version:
- Chrome (iOS) version:
- Firefox version:
- Safari (desktop) version:
- Safari (iOS) version:
- IE version:
- Edge version:
For development issues:
- Node version:
- Operating System:
Additional Description
Probably makes more sense to fix in the cubic api, since this should in theory affect all endpoints: https://github.com/cubic-js/cubic/blob/development/packages/api/middleware/native/http.js#L17