Change request: column type selection when creating new building block
akirbis opened this issue · 4 comments
Current situation
When adding a new building block to an annotation table, the column type can be selected from a drop-down menu. The current options are:
Parameter, Factor, Characteristic, Component, Date, Performer, Protocol
Change request
According to ISA-XLSX specification, allowed column types for annotation tables are:
Characterisitc, Factor, Parameter, Component, Comment +
5 different protocol column types: Protocol REF, Protocol Version, Protocol Description, Protocol Uri, Protocol Type
All other column types are out of scope of the specification, so it would probably be a good idea to remove Date, Performer, Protocol from the current selection and add Comment, as well as the 5 protocol column types, instead.
I removed Date and Performer and added Comment and the different protocol columns as you mentioned.
Also have I changed the way you add protocol columns now. Instead of adding the 5 type of protocols to the list I added a checkbox for each protocol. It more asthetic and user friendly that way, as you now can add mutliple column types at once.
I will push the change later to the live version and the repo, as soon as I added the other stuff.
Looks good so far, thanks for the quick adjustment!
Two small additions:
(1) It looks like the new protocol column names don't have whitespace characters in the annotation table. I think the whitespace is part of the specification, so it should also occur in the column name fields (e.g. "Protocol Type" instead of "ProtocolType".
(2) All protocol columns are limited to occur at most one time in each annotation table. Can we somehow prevent users from adding more than one column of each type?
I think the ProtocolType and ProtocolREF you see on the screenshot came from a template.
Because when you add the protocol columns it should look like this:
(you can also see the arrows to move the columns already ^^)
I also added a check whether the exact protocol columns, you want to add, aren't already there.
Therefore it shouldn't be possivle to add more than one of each type of protocol column.
changed in new version 0.9.2