IE shows icons with vertical offset

Question

IE shows icons with vertical offset

Closed this issue 8 years ago · 9 comments

Note that for this to work it relies on a version bump in gulp-svg2ttf, which is also sitting in a PR there. So I'd merge that one in, then the CI build will pass for this.

Fix with version bump here:
#119

RobeeeJay commented 8 years ago

Thanks!

Answer 1 · 2016-04-01T11:57:45.000Z

@nfroidure any chance of this PR being merged? :(

Answer 2 · 2016-04-01T13:15:06.000Z

Hi, sorry about that. Had no time to work on it. Since the build fails, it needs a bit of work to get it work https://travis-ci.org/nfroidure/gulp-svg2ttf/jobs/114551504

Answer 3 · 2016-04-01T13:26:22.000Z

Thanks for the response! I suspect build is broken because of the matching PR in svg2tff that also needs merging:
nfroidure/gulp-svg2ttf#7

But that appears broken too according to travis, quite why I'm not sure. I don't really understand what the tests are checking. :(

Answer 4 · 2016-04-01T13:32:11.000Z

They are are just checking the ttf font remain the same so i know when something changed. Not perfect but it's better than nothing.

Answer 5 · 2016-05-05T15:06:26.000Z

Are you discontinuing gulp-iconfont and gulp-svg2ttf? :(

Answer 6 · 2016-05-06T06:27:56.000Z

I have less time to give for gulp-iconfont and that's why i can't merge PRs that do not keep the tests working. Fixing tests in gulp-svg2ttf will get the PR merged and the module published.

Answer 7 · 2016-05-06T12:13:53.000Z

Tests in gulp-svg2ttf fixed!

Answer 8 · 2016-05-10T12:04:46.000Z

Thanks, published as gulp-iconfont 8.0.0