nfroidure/gulp-iconfont

source files are deleted

Closed this issue · 3 comments

shadowmint commented

When I run the task:

  return gulp.src([`${config.fontsvg}/**/*.svg`, `${config.custom}/**/*.svg`])
      .pipe(iconfont({
        fontName: 'eggbox',
        appendUnicode: true,
        formats: ['ttf', 'eot', 'woff', 'svg']
      }))
.pipe(gulp.dest(config.fonts));

...then look in the folder where the source files are, I many files are created and deleted:

Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    deleted:    _icon-template.svg
    deleted:    src/alert-fill.svg
    deleted:    src/arrow-full-down.svg
    deleted:    src/arrow-full-left.svg
    deleted:    src/arrow-full-right.svg
    deleted:    src/arrow-full-up.svg
    deleted:    src/arrow-fullinverted-down.svg
    deleted:    src/arrow-fullinverted-left.svg
    deleted:    src/arrow-fullinverted-right.svg
    deleted:    src/arrow-fullinverted-up.svg
    deleted:    src/arrow-hairline-down.svg
    deleted:    src/arrow-hairline-left.svg
    deleted:    src/arrow-hairline-right.svg
    deleted:    src/arrow-hairline-up.svg
    deleted:    src/arrow-keyline-down.svg
    deleted:    src/arrow-keyline-left.svg
    deleted:    src/arrow-keyline-right.svg
    deleted:    src/arrow-keyline-up.svg
    deleted:    src/arrow-outline-down.svg
    deleted:    src/arrow-outline-left.svg
    deleted:    src/arrow-outline-right.svg
    deleted:    src/arrow-outline-up.svg
    deleted:    src/battery-50.svg
    deleted:    src/battery-full.svg
    deleted:    src/battery-low.svg
    deleted:    src/bell.svg
    deleted:    src/book-closed.svg
    deleted:    src/book-open.svg
    deleted:    src/bookmark.svg
    deleted:    src/calendar.svg
    deleted:    src/check.svg
    deleted:    src/checkbox-blank.svg
    deleted:    src/checkbox-checked.svg
    deleted:    src/clock.svg
    deleted:    src/coffeecup.svg
    deleted:    src/comment.svg
    deleted:    src/contract.svg
    deleted:    src/conversation.svg
    deleted:    src/cross-large.svg
    deleted:    src/cross-small.svg
    deleted:    src/documents.svg
    deleted:    src/download.svg
    deleted:    src/edit.svg
    deleted:    src/email-closed.svg
    deleted:    src/email-open.svg
    deleted:    src/equaliser-horz.svg
    deleted:    src/equaliser-vert.svg
    deleted:    src/expand.svg
    deleted:    src/facebook-fill.svg
    deleted:    src/facebook.svg
    deleted:    src/favourite.svg
    deleted:    src/flag.svg
    deleted:    src/forbidden.svg
    deleted:    src/foursquare-inverted.svg
    deleted:    src/foursquare.svg
    deleted:    src/googleplus.svg
    deleted:    src/handshake.svg
    deleted:    src/heart.svg
    deleted:    src/help-inverse.svg
    deleted:    src/help.svg
    deleted:    src/home.svg
    deleted:    src/image.svg
    deleted:    src/info-fill.svg
    deleted:    src/info.svg
    deleted:    src/instagram-video.svg
    deleted:    src/instagram.svg
    deleted:    src/link.svg
    deleted:    src/linked.svg
    deleted:    src/linkedin-fill.svg
    deleted:    src/location-pointer.svg
    deleted:    src/lock-locked.svg
    deleted:    src/lock-unlocked.svg
    deleted:    src/logout-1.svg
    deleted:    src/logout-2.svg
    deleted:    src/mapmarker.svg
    deleted:    src/menutoggle.svg
    deleted:    src/microphone.svg
    deleted:    src/minus.svg
    deleted:    src/paperclip.svg
    deleted:    src/phone.svg
    deleted:    src/plus.svg
    deleted:    src/presentation.svg
    deleted:    src/print.svg
    deleted:    src/profile-2.svg
    deleted:    src/profile.svg
    deleted:    src/refresh.svg
    deleted:    src/reply.svg
    deleted:    src/retweet.svg
    deleted:    src/rss-fill.svg
    deleted:    src/rss.svg
    deleted:    src/search.svg
    deleted:    src/settings-spanner.svg
    deleted:    src/settings.svg
    deleted:    src/stopwatch.svg
    deleted:    src/sync-1.svg
    deleted:    src/sync-2.svg
    deleted:    src/tab.svg
    deleted:    src/timer.svg
    deleted:    src/trash.svg
    deleted:    src/twitter-fill.svg
    deleted:    src/twitter.svg
    deleted:    src/upload.svg
    deleted:    src/vcard.svg
    deleted:    src/view.svg
    deleted:    src/youtube.svg
    deleted:    src/zoom-in.svg
    deleted:    src/zoom-out.svg

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    src/uEA03-alert-fill.svg
    src/uEA04-arrow-full-down.svg
    src/uEA05-arrow-full-left.svg
    src/uEA06-arrow-full-right.svg
    src/uEA07-arrow-full-up.svg
    src/uEA08-arrow-fullinverted-down.svg
    src/uEA09-arrow-fullinverted-left.svg
    src/uEA0A-arrow-fullinverted-right.svg
    src/uEA0B-arrow-fullinverted-up.svg
    src/uEA0C-arrow-hairline-down.svg
    src/uEA0D-arrow-hairline-left.svg
    src/uEA0E-arrow-hairline-right.svg
    src/uEA0F-arrow-hairline-up.svg
    src/uEA10-arrow-keyline-down.svg
    src/uEA11-arrow-keyline-left.svg
    src/uEA12-arrow-keyline-right.svg
    src/uEA13-arrow-keyline-up.svg
    src/uEA14-arrow-outline-down.svg
    src/uEA15-arrow-outline-left.svg
    src/uEA16-arrow-outline-right.svg
    src/uEA17-arrow-outline-up.svg
    src/uEA18-battery-50.svg
    src/uEA19-battery-full.svg
    src/uEA1A-battery-low.svg
    src/uEA1B-bell.svg
    src/uEA1C-book-closed.svg
    src/uEA1D-book-open.svg
    src/uEA1E-bookmark.svg
    src/uEA1F-calendar.svg
    src/uEA20-check.svg
    src/uEA21-checkbox-blank.svg
    src/uEA22-checkbox-checked.svg
    src/uEA23-clock.svg
    src/uEA24-coffeecup.svg
    src/uEA25-comment.svg
    src/uEA26-contract.svg
    src/uEA27-conversation.svg
    src/uEA28-cross-large.svg
    src/uEA29-cross-small.svg
    src/uEA2A-documents.svg
    src/uEA2B-download.svg
    src/uEA2C-edit.svg
    src/uEA2D-email-closed.svg
    src/uEA2E-email-open.svg
    src/uEA2F-equaliser-horz.svg
    src/uEA30-equaliser-vert.svg
    src/uEA31-expand.svg
    src/uEA32-facebook-fill.svg
    src/uEA33-facebook.svg
    src/uEA34-favourite.svg
    src/uEA35-flag.svg
    src/uEA36-forbidden.svg
    src/uEA37-foursquare-inverted.svg
    src/uEA38-foursquare.svg
    src/uEA39-googleplus.svg
    src/uEA3A-handshake.svg
    src/uEA3B-heart.svg
    src/uEA3C-help-inverse.svg
    src/uEA3D-help.svg
    src/uEA3E-home.svg
    src/uEA3F-image.svg
    src/uEA40-info-fill.svg
    src/uEA41-info.svg
    src/uEA42-instagram-video.svg
    src/uEA43-instagram.svg
    src/uEA44-link.svg
    src/uEA45-linked.svg
    src/uEA46-linkedin-fill.svg
    src/uEA47-location-pointer.svg
    src/uEA48-lock-locked.svg
    src/uEA49-lock-unlocked.svg
    src/uEA4A-logout-1.svg
    src/uEA4B-logout-2.svg
    src/uEA4C-mapmarker.svg
    src/uEA4D-menutoggle.svg
    src/uEA4E-microphone.svg
    src/uEA4F-minus.svg
    src/uEA50-paperclip.svg
    src/uEA51-phone.svg
    src/uEA52-plus.svg
    src/uEA53-presentation.svg
    src/uEA54-print.svg
    src/uEA55-profile-2.svg
    src/uEA56-profile.svg
    src/uEA57-refresh.svg
    src/uEA58-reply.svg
    src/uEA59-retweet.svg
    src/uEA5A-rss-fill.svg
    src/uEA5B-rss.svg
    src/uEA5C-search.svg
    src/uEA5D-settings-spanner.svg
    src/uEA5E-settings.svg
    src/uEA5F-stopwatch.svg
    src/uEA60-sync-1.svg
    src/uEA61-sync-2.svg
    src/uEA62-tab.svg
    src/uEA63-timer.svg
    src/uEA64-trash.svg
    src/uEA65-twitter-fill.svg
    src/uEA66-twitter.svg
    src/uEA67-upload.svg
    src/uEA68-vcard.svg
    src/uEA69-view.svg
    src/uEA6A-youtube.svg
    src/uEA6B-zoom-in.svg
    src/uEA6C-zoom-out.svg
    uEA02-_icon-template.svg

Seems bad.

Gulp plugins should not have side effects on source files.

nfroidure commented

Feel free to not use ;):

        appendUnicode: true,
shadowmint commented

Sounds like at the very least you should add to the readme what that feature does...

Of course, you're completely right; ultimately I chose not to use this plugin at all, as using the individual gulp plugins for each font was more compositable.

/shrug