ng2-ui/overlay

ng2-overlay imports BrowserModule, should import CommonModule

dozer75 opened this issue · 4 comments

The ng2-overlay component imports BrowserModule, this causes code that is built upon lazy loaded modules to fail with the following message:

EXCEPTION: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.
Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

The import of the BrowserModule should be the responsibility to the base loader and not be done in a component like this. Please use CommonModule instead.

Added a Pull Request for this #2

Thank you

Nice, I hope an updated NPM package is on it's way to.

published as v0.6.3