ngageoint/sarpy

_ric_ecf_mat bug

Closed this issue · 1 comments

Hello, I believe that there is a bug with this function.

https://github.com/ngageoint/sarpy/blob/11d19a0440725181678cff89873c6f2315c6a96d/sarpy/geometry/point_projection.py#L124C5-L124C17

On line 154:

return numpy.array([r, i, c], dtype='float64')

should be

return numpy.array([r, i, c], dtype='float64').T

Adding the transpose makes this function return the same value as the Matlab equivalent. See page 26-27 in the SICD Volume 3 document. I could be using the function incorrectly though.

Included in version 1.3.59