nginx/ansible-role-nginx-config

deployment_location functionality appears to be incomplete

Closed this issue · 1 comments

hancockjt commented

Describe the bug

Comments in the commit history indicate that for nginx_config_main_template, the child variables conf_file_name and conf_file_location have been replaced by deployment_location. This appears to be only partially implemented. The code still looks for the removed variables:
https://github.com/nginxinc/ansible-role-nginx-config/blob/0.4.0/tasks/config/template-config.yml#L32
https://github.com/nginxinc/ansible-role-nginx-config/blob/0.4.0/tasks/config/template-config.yml#L60

If your folder is anything other than the default, it won't get created.

Recommendations:

  • use {{ ... | dirname }} on the deployment_location to extract the directory name
  • implement this for streams too
alessfg commented

You would be correct. I'll have a bug fix ready early next week. (Stream configs are also going to be refactored in a similar fashion to HTTP configs so that change will happen in due time.)