nginxinc/nginx-ingress-operator

Propagate extra labels and annotations to workloads

sagikazarmark opened this issue · 4 comments

sagikazarmark commented

Is your feature request related to a problem? Please describe.
I'd like to ingest a sidecar container into the nginx ingress pod and configure it using annotations, but currently no labels or annotations are propagated to workload objects (deployment/daemonset, pod).

Describe the solution you'd like
Propagate extra labels/annotations to workload objects.

Additional context
There are a couple different approaches this could take:

  • Propagate labels/annotations to both deployments/daemonsets and pods
  • Propagate them to pods only
  • Propagate them to deployments/daemonsets only

Another thing to decide is whether these labels/annotations are considered "extra" (ie. are they extraAnnotations or just annotations). Following existing conventions in the operator, it's the first one.

sagikazarmark commented

Hey @lucacome

Maybe you have some thoughts on this issue (or the linked one)

Thanks!

github-actions commented

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions commented

This issue was closed because it has been stalled for 10 days with no activity.

sagikazarmark commented

I believe this should be reopened.