Broken images in README.md
fabriziofiorucci opened this issue ยท 4 comments
These two links are broken:
The offending lines are
https://github.com/nginxinc/nginx-openid-connect/blob/main/README.md?plain=1#L9
https://github.com/nginxinc/nginx-openid-connect/blob/main/README.md?plain=1#L22
I have a mermaid diagrams for the images - it might be a better way forwards. Happy to submit a PR from my fork
See https://github.com/lcrilly/nginx-openid-connect/blob/master/README.md
Hi @lcrilly ,
I've been aware of your fork for some time and was actually curious why this hadn't been suggested earlier! :)
The idea of replacing the current bin images with mermaid diagrams sounds excellent. It wold make maintain the docs easier and ensure that the diagrams are always up-to-date with the source code.
Please feel free to submit a PR from your fork!
Ha! I just did it to learn Mermaid and then kinda forgot about it. Will submit a PR soon.