nginxinc/nginx-s3-gateway

Arm64 build

maxemann96 opened this issue · 7 comments

maxemann96 commented

Is your feature request related to a problem? Please describe.
I want to run a kubernetes cluster with only arm64 nodes, as a result I need an arm64 build for every software I use.

Describe the solution you'd like
Also building a docker image for arm64

Describe alternatives you've considered
No alternatives

Additional context
The nginx base image is already available as arm64

Thanks in advance for creating and maintaining this image. Very useful for my use case.

4141done commented

Hello!

Thank you for bringing this up! It is on my list of things to do but having someone complain certainly helps with prioritization. You should see this change coming in fairly soon. See my reply to this issue regarding a refactor I'm doing at the moment to decouple the integration tests from the build process and move the integration test suite into Javascript. I'm tracking that work here: #191

hmehta commented

Hi!

This would be so wonderful! We are moving from AMD64->ARM64 and this is one of the few things we are using that not yet supports ARM64. So a big upvote from here for bumping this up a notch on the todo list :)

  • 👍1
ehginanjar commented

Hi @maxemann96

I've had similar case, building the image so I can test it on my M1 Pro. In this case I used docker, so I tried to build the image by using this command docker buildx build --platform linux/arm64. Source. So maybe this solution can be tested on your side as well. Cheers!

  • ❤️1
4141done commented

@maxemann96 and @hmehta : I have a provisional PR for an overhaul of the build and test pipeline in case you have comments here: #197
You don't necessarily have to review it but any comments are welcome.

More importantly, it produced a test image that you can see here: https://github.com/nginxinc/nginx-s3-gateway/pkgs/container/nginx-s3-gateway%2Fnginx-oss-s3-gateway/166168166?tag=latest-new-build-test

Would you mind testing to see if this works for you?

  • ❤️1
maxemann96 commented

@4141done the test image is running properly, thanks :)

hmehta commented

@4141done I confirm that the image works for us too. Thanks a lot!

4141done commented

Thank you both for confirming. Arm64 images will start being built after that PR is merged. I'm just waiting on code review from my co-maintainers.