Multiple phone numbers from `randPhoneNumber()`
matt0089 opened this issue · 3 comments
matt0089 commented
Is this a regression?
No
Description
When making multiple calls of falso.randPhoneNumber(), sometimes it returns multiple phone numbers
E.g.
> falso.randPhoneNumber()
'+232 76 131814'
> falso.randPhoneNumber()
'+672 156 512'
> falso.randPhoneNumber()
'+850 191 997 0805'
> falso.randPhoneNumber()
'+975 17 322 723, +975 6 166 883'
...It looks like just some simple typos forgetting quotes. Here's an example:
https://github.com/ngneat/falso/blob/main/packages/falso/src/lib/phone-number.json#L120
I can make a PR soon if you want.
Thank you for this package, it's been great so far. In particular, the rand() function is really convenient and intuitive.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in
node v14
Anything else?
No response
Do you want to create a pull request?
Yes
NetanelBasal commented
You're welcome to create a PR, thanks.
tahseenio commented
I am able to work on this.
matt0089 commented
Thank you guys! Sorry I missed coming back to this