Other: Sign in Sign up buttons in Navbar
Saekit opened this issue · 9 comments
What would you like to share?
I would like to propose some style changes to the Sign in/Sign up buttons in the navbar.
- Change "Sign in" to "Log in" for better UI/UX experience, also to match the footer
- Change the style of the Log in button to only have an underline (on hover), so it differentiates from the Sign up button
- Align all nav items
Issues:
Funny looking button behavior:
Screen.Recording.2023-10-31.at.2.30.09.PM.mov
Misalignment:
Solution:
🥦 Browser
Google Chrome
Checklist ✅
- I checked and didn't find similar issue
- I have read the Contributing Guidelines
- I am willing to work on this issue (blank for no)
Hello @Saekit, thank you for raising the issue.
Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
Sounds good to me however, I would also like to suggest some changes.
- The buttons can be changed, instead of having two, we can have one.
- We just keep a main button, which says
Sign Inor something like that (check the screenshot below) - Also the line height probably is probably causing some issues with the misalignment.
@tamalCodes Just to clarify, are you suggesting completely removing the Sign up button from the navbar and only having a log in button that keeps the current style?
sir can you please assign this issue to me ?
@tamalCodes Just to clarify, are you suggesting completely removing the Sign up button from the navbar and only having a log in button that keeps the current style?
Yes
can i work on it as it available i know it
Hi there @tamalCodes i went through the conversation above. I guess i can the fix this issue.
Hey @tamalCodes, I've made the changes locally. Could you please assign the issue to me? It will be helpful for me to create a pull request.
Hey I would love to work on this issue.