ngx-translate/http-loader

Incorrect peer dependencies

RoopeHakulinen opened this issue · 4 comments

In package.json there's the following block:

"peerDependencies": {
  "@ngx-translate/core": ">=6.0.0",
  "@angular/core": ">=4.3.1",
  "@angular/http": ">=4.3.1"
},

where there seems to be a peerDependency for @angular/http which the package doesn't depend on anymore as it is now based on the new HttpClient. Instead peerDependency should point to @angular/common which includes the @angular/common/http and thus the HttpClient.

While on the topic of peerDependencies, is 2.3.1 the correct version to be required as it is already the 2.3.0 that implements the HttpClient? Might be that there's some bug in 2.3.0 that was only fixed on 2.3.1.

good point, can you make a PR to fix this please? And no, 4.3.0 is enough

Sure, just a sec.

Here you go: #18

thanks