ngxtension/ngxtension-platform

Package "ngxtension" has a missing peer dependency of "@use-gesture/vanilla" @ "^10.0.0".

kle-pra opened this issue · 3 comments

I noticed this warning when running update script and am opening just in case it needs some attention.

We are not using gestures so it doesn't seem to affect us but would you still recommend installing this as a dependency when using ngxtension version. 3.x?

Hello @kle-pra .
That's an optional dependency. You don't need to install it.

@nartc
Should we add optional to it?

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta

"peerDependenciesMeta": {
    "@use-gesture/vanilla": {
      "optional": true
    }
  }

I think if project dos not use gesture it is misleading, I'm in favor of optional

Thanks @eneajaho for explanation and suggestion, I also support optional.