nhost/hasura-storage

Storage.buckets table should be enum

spakanati opened this issue · 4 comments

Similar to nhost/nhost#946 which is about the user roles table, the storage.buckets table should be set as enum in Hasura. This would allow for generated types.

How would we prevent introducing a breaking change?

I don't think this can be introduced without a breaking change. We should wait to implement this until users can configure their versions with Nhost.

Moving this issue to the Hasura Storage repo.

I don't think this should be an enum. Buckets are dynamic objects that can be created or removed following any logic users desire. While for some users treating buckets as enum may work we can't generalize this as others users may need to manage them dynamically.

We spoke about this internally, and given buckets are relatively dynamic, and Hasura requires the metadata to be reloaded for enums to be updated, we don't think it's a good idea to have buckets be enum.