nhost/hasura-storage

Forwarding Content-Length and Content-Type breaks upload flow

jhleao opened this issue · 1 comments

jhleao commented

Hasura Storage normally forwards all incoming headers from the upload request to HGE when performing tasks such as intializing metadata. This causes Content-Length and Content-Type to be forwarded as well, which are normally referring to a multipart form data and more or less the size of the uploaded file.

When sending these headers over to HGE to perform plain GraphQL operations, they become inconsistent with the actual body of the requests (i.e. a GraphQL JSON request body, not multipart for data and not of that size).

Certain webservers break with this: we were using Hasura Cloud at some point, and never had a problem with this inconsistency. Though when switching to self hosted Hasura under Azure App Services, the App Services platform webserver couldn't handle the request and it wouldn't event reach HGE.

I would normally open a pull request with the fix (it's simply filtering out these headers on ForWardHeadersAuthorizer), but beucase of #182, I'm unable to run and test v0.4.0. We are running a custom v0.3.6 at the moment.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.