aiosocks.LoginAuthenticationFailed is not raised on auth error
Opened this issue · 0 comments
jruere commented
Instead, aiosocks.SocksError is raised saying there was an auth error.
AFAICS, this happens because in aiosocks.protocols.BaseSocksProtocol.negotiate, on line 58, exception aiosocks.SocksError is caught, which is a parent of aiosocks.LoginAuthenticationFailed and a brand new aiosocks.SocksError is created and raised.
No idea why that is done but the result is that aiosocks.LoginAuthenticationFailed never actually reaches the code using aiosocks.
Is this intentional?