nical/guillotiere

SimpleAtlasAllocator::allocate() seems to always return None

Imberflur opened this issue · 6 comments

Imberflur commented

guillotiere/src/allocator.rs

Line 1244 in 354b0d5

return None;

Imberflur commented

I think this is the correct fix, but I'm not completely sure.
Imberflur@42c298f

nical commented

Oops! Indeed. Your fix is correct, and an even simpler fix is to return result directly.
I'll put a fix up soon unless you'd like to be the one submitting the PR.

Imberflur commented

I'm fine not submitting a PR. I tried just returning result and I think sometimes the returned rectangle is to large? I.e. larger than what was requested and larger than what is actually allocated.

nical commented

Indeed, my bad again, sorry. I haven't had time to look into this code for a while.

Imberflur commented

Awesome! Thanks for taking the time to look into this.