nicdard/compiler-design-eth-tests

Authors file?

Closed this issue · 3 comments

@dbernhard-0x7CD tagging you since you are adding a good quantity of new tests.

I was thinking that if the other assignments are also having tests, it can be good to add an author file maybe? Or license on top of each file?

I would however keep all the file for each assignment in one file only so we can simply copy paste the whole thing to try out our implementation.

Otherwise we can have multiple suites, each of them gathering the test of an author such as:

let nicdard_provided_tests = [ ... ]
let dbernhard_provided_tests = [ ... ]

and then merge all of them (since those are simply list of assertion test).

Given that now more people contributed to these tests we would also benefit from having one file per author to minimize the effort for merges/rebases in the actual studenttests.ml. Then we have a sharedtests.ml which provides only the suites. And then we modify our main.ml to also include the sharedtests.ml (which is the cloned subdirectory of this repository).
Now we only have to pull this repo and can run all tests at once; and not have to copy tests around.

But do as you wish (and/or is more conventient for you) :)

I like the idea! I would also suggest to add another shared file for utility test functions we write, so every one can reuse them without polluting to much the test harness given with the project

Sounds great 👍